This repository was archived by the owner on Sep 18, 2024. It is now read-only.
Open
Conversation
Contributor
|
Switching to tf_addons is a pretty big change so I will reach out to Francois. Thank you for the PR! |
Contributor
Author
|
I think, there's no reason to keep "external" dependencies. I would suggest
to get rid of numpy too.
…On Thu, Jan 21, 2021, 6:19 PM Frédéric Branchaud-Charron < ***@***.***> wrote:
Switching to tf_addons is a pretty big change so I will reach out to
Francois.
Thank you for the PR!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#334 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASS73RSVVMIYW4Z7YQCZULS3BHZDANCNFSM4WMUHG6A>
.
|
Contributor
Author
|
In fact we do not need anything but TF here. Instead of P. S. |
Contributor
|
Once tensorflow/tensorflow#46637 is merged I think we can merge this pr. Thank you! |
Contributor
Author
They will not approve it because it breaks internal tests (that are relying on the current behavior). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
PR Overview
This is the second (last) part of the effort to remove SciPy dependency (#322)
Note: currently two tests are failing because of a bug tensorflow/addons#2357. Since the issue is not critical -- it only affects boundaries, we can adjust unit tests to follow the buggy behavior of
tensorflow-addons.